Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstaller strips off "/" and "-" in switches #212

Closed
ferventcoder opened this issue Mar 29, 2015 · 0 comments
Closed

Uninstaller strips off "/" and "-" in switches #212

ferventcoder opened this issue Mar 29, 2015 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug
Milestone
0.9.9.6

Comments

@ferventcoder
Copy link
Member 

adobereader v11.0.10
 Running auto uninstaller...
 Preparing uninstall key 'MsiExec.exe /I{AC76BA86-7AD7-1033-7B44-AB0000000001}'
 Uninstaller path is 'C:\Windows\system32\MsiExec.exe'
 Installer type is 'MsiInstaller'
 Args are 'I{AC76BA86-7AD7-1033-7B44-AB0000000001} /qn /norestart '
Calling command ['"C:\Windows\system32\MsiExec.exe" I{AC76BA86-7AD7-1033-7B44-AB
0000000001} /qn /norestart ']
Command ['"C:\Windows\system32\MsiExec.exe" I{AC76BA86-7AD7-1033-7B44-AB00000000
01} /qn /norestart '] exited with '1639'
 Auto uninstaller failed. Please remove machine installation manually.
adobereader uninstall not successful.
 Auto uninstaller failed. Please remove machine installation manually.
@ferventcoder ferventcoder modified the milestones: 0.9.9.4, 0.9.9.5 Mar 29, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.9.5, 0.9.9.6 Apr 20, 2015
@ferventcoder ferventcoder changed the title Uninstaller strips items off of arguments when no silent uninstall key is present Uninstaller strips off "/" and "-" in switches Apr 22, 2015
ferventcoder added a commit that referenced this issue Apr 22, 2015
@ferventcoder
(GH-212) Do not strip switch char from uninstall args
4bb65a8 
Previously, when building uninstall args, the uninstaller service was
splitting on ` /` and ` -`. While this was very accurate in finding the
first argument (the executable), it removed the switch characters from
the args. Use the same method to find the first argument to shift it
off, but then go back to the original uninstall string to gather the
arguments, removing the executable from that.

Additionally fix specs and improve clarity of the tests.
ferventcoder added a commit that referenced this issue Apr 22, 2015
@ferventcoder
Merge branch 'stable'
eeadfb6 
* stable:
  (GH-212) Do not strip switch char from uninstall args
  (maint) Use installshield installer when installshield
  (GH-255) Uninstaller should not depend on InstallLocation
  (GH-255) Add updateProcessPath to CommandExecutor
  (maint) formatting
  (GH-254) Ensure nupkg is removed on uninstall
  (doc) update help menus
@ferventcoder ferventcoder self-assigned this Apr 22, 2015
@ferventcoder ferventcoder mentioned this issue May 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug
Projects
None yet
Milestone
0.9.9.6
Development

No branches or pull requests
2 participants
@ferventcoder @gep13