Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning message about "smarter than the average bear" #3186

Closed
2 tasks done
tranquilcarbon opened this issue Jun 1, 2023 · 6 comments · Fixed by #3276
Closed
2 tasks done

Remove warning message about "smarter than the average bear" #3186

tranquilcarbon opened this issue Jun 1, 2023 · 6 comments · Fixed by #3276
Labels
5 - Released Improvement
Milestone
2.2.0

Comments

@tranquilcarbon
Copy link

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When i ran choco upgrade all today, i received the following message:
crystaldiskinfo v9.0.1 is newer than the most recent. You must be smarter than the average bear...

i was initially panicked as i thought the package had been compromised and that it was a message left behind. After completing a full scan of my computer (which returned no infections) When i searched it, i discovered this was a easter egg.

Describe The Solution. Why is it needed?

I believe that a option to switch it off is needed, as it may cause panic to users who do not know that it is a easter egg and therefore might cause unnecessary stress to them.

Additional Context

No response

Related Issues
@pauby pauby added this to the vNext milestone Jun 1, 2023
pauby added a commit to pauby/choco that referenced this issue Jul 20, 2023
@pauby
(chocolatey#3186) Remove easter egg
1fb8c8c
@pauby pauby mentioned this issue Jul 20, 2023
Merged
10 tasks
@gep13 gep13 changed the title The ability to disable easter eggs Remove warning message about "smarter than the average bear" Jul 25, 2023
@gep13 gep13 modified the milestones: vNext, 2.2.0 Jul 25, 2023
gep13 pushed a commit to pauby/choco that referenced this issue Jul 25, 2023
@pauby @gep13
(chocolatey#3186) Remove easter egg
436ad3f
gep13 added a commit that referenced this issue Jul 25, 2023
@gep13
Merge pull request #3276 from pauby/enhance/remove-easter-egg
18bacb8 
(#3186) Remove easter egg "You are smarter than the average bear ..."
@gep13 gep13 added 4 - Done and removed 3 - Review labels Jul 25, 2023
gep13 added a commit that referenced this issue Jul 26, 2023
@gep13
Merge branch 'release/2.2.0'
76b9ca9 
* release/2.2.0: (21 commits)
  (doc) Update to indicate new package version used
  (maint) Add helper to split on max line lengths
  (#3281) Add validation for cache folder permissions
  (#3264) Update to latest Chocolatey.NuGet.Client
  (#3264) Ignore lock folders in cache directories
  (#3186) Remove easter egg
  (doc) Improve error message for defaultPushSource
  (tests) Clear HTTP Cache before getting packages
  (#3258) Expand logging for nuget resources errors
  (maint) Set file encoding to include BOM
  (#3237) Reduce number of queries for dependencies
  (#3231) Add tests to ensure package listing
  (maint) Remove unnecessary using statements
  (#3231) Don't refresh local package info during upgrade no-ops
  (build) Update to latest recipe package
  (doc) Minor corrections to wording
  (#3242) Add a script to run Authenticated tests
  (#3242) Attempt default credentials for sources
  (maint) Fix incorrect naming style uses
  (doc) Apply scripting best practices to output
  ...
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@darksidemilk
Copy link

Can I actually request this be un-done?
Easter eggs like this are one of my favorite things in our professional world, and if we can't have a little bit of silly in a product named "chocolatey", then just where's the fun in that? It is still a valid concern and maybe there could be an official doc page linked to the message to quell any concerns of it not being an official message rather than just removing it completely?

@pauby
Copy link
Member

pauby commented Aug 1, 2023 •
edited
Loading

@darksidemilk We have no plans to add this back in, unfortunately.

@tranquilcarbon
Copy link
Author

Can I actually request this be un-done?

Easter eggs like this are one of my favorite things in our professional world, and if we can't have a little bit of silly in a product named "chocolatey", then just where's the fun in that? It is still a valid concern and maybe there could be an official doc page linked to the message to quell any concerns of it not being an official message rather than just removing it completely?

I completely disagree. A Easter egg should only appear when certain actions are done that the user is knowingly repeating. This Easter egg causes unnecessary confusion since it is not clear why it is occurring.

@ferdnyc
Copy link

ferdnyc commented Sep 1, 2023

I've gotta side with @tranquilcarbon on this one.

I'm all for whimsey and silliness in all parts of life, software included. The VLC traffic cone putting on its Santa hat is one of the highlights of my year. I'm still disappointed the "You can tune a filesystem, but you can't tune a fish." message from the BSD tunefs(8) man page never made it to Linux's tune2fs(8) man page. But like so many things, it's all in the execution.

And that's where this particular message had a lot of strikes against it:

  1. Easter eggs should be something you can either stumble across, or intentionally trigger, not something that imposes itself into your normal workflow without warning. That's not an easter egg, that's a jumpscare.
  2. The message has no obvious relationship to Chocolatey, so it fails as an in-joke / fanservice.
  3. As a cultural reference, it's older than I am, and I am not young. (Heck, it's almost as old as that "...tune a fish" message.) Who is it even for?

@jpluimers
Copy link

What I really miss in the message is that it does not hint at the most likely cause: that the newer version likely has been retracted.

It would be nice if in a future version enough meta-data would become available to better indicate the cause of the message.

@chocolatey chocolatey locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
5 - Released Improvement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

(#3186) Remove easter egg "You are smarter than the average bear ..." pauby/choco
7 participants
@ferdnyc @gep13 @jpluimers @choco-bot @darksidemilk @pauby @tranquilcarbon