Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3186) Remove easter egg "You are smarter than the average bear ..." #3276

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

pauby
Copy link
Member

@pauby pauby commented Jul 20, 2023

Description Of Changes

Removed 'You are smarter than the average bear...' from being displayed.

Motivation and Context

It's fun, and it's been there for some time, but from issue #3186 the humour maybe doesn't travel well. Rather than adding a feature just to turn this off, I don't think there is anything lost by removing it.

I wasn't sure whether to remove the final newline, so let me know.

This isn't parsable output, so I don't believe this is a breaking a change.

Testing

None. This is just removing a string of text.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #3186

@pauby pauby requested a review from gep13 July 20, 2023 15:15
@gep13 gep13 force-pushed the enhance/remove-easter-egg branch from 1fb8c8c to 436ad3f Compare July 25, 2023 09:24
@gep13
Copy link
Member

gep13 commented Jul 25, 2023

@pauby said...
I wasn't sure whether to remove the final newline, so let me know.

I have updated this PR to remove the final Environment.Newline, as this is not required, following the other change that you made.

@pauby said...
This isn't parsable output, so I don't believe this is a breaking a change.

Agreed.

@gep13 gep13 enabled auto-merge July 25, 2023 09:26
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 18bacb8 into chocolatey:develop Jul 25, 2023
@gep13
Copy link
Member

gep13 commented Jul 25, 2023

@pauby thanks for getting this updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warning message about "smarter than the average bear"
2 participants