Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choco upgrade not downloading new installer if current installer is the same size. #405

Closed
timbrown5 opened this issue Sep 10, 2015 · 1 comment
Closed

Choco upgrade not downloading new installer if current installer is the same size. #405

timbrown5 opened this issue Sep 10, 2015 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Bug
Milestone
0.9.9.9

Comments

@timbrown5
Copy link

As discussed here:
https://groups.google.com/d/msgid/chocolatey/9159c198-6103-4679-839c-9eb3de639628%40googlegroups.com?utm_medium=email&utm_source=footer

If an already installed chocolatey package is the same size as the one in the cache, chocolatey does not download the new installer, and so the wrong version is installed.

The end result is that chocolatey think it has updated the package, but has just re-installed the version already on the system.
@ferventcoder
Copy link
Member

This should hopefully be corrected by downloading each installer to a subfolder with the version. And using the original name of the file (I thought we had an issue filed on these, but apparently not over in choco, perhaps still in the older chocolatey repo).

@ferventcoder ferventcoder added this to the 0.9.10.x milestone Sep 10, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.9.9, 0.9.10.x Sep 23, 2015
@ferventcoder ferventcoder self-assigned this Sep 23, 2015
ferventcoder added a commit to ferventcoder/choco that referenced this issue Sep 23, 2015
@ferventcoder
(chocolateyGH-405) Cache downloads by name and version
e15c3eb 
When downloading files from the internet, cache the file in a folder
with the package name and the package version. This way the package
isn't mistaken for a different version when the file sizes match (when
checksumming isn't used).
ferventcoder added a commit to ferventcoder/choco that referenced this issue Sep 23, 2015
@ferventcoder
Merge branch 'stable'
9c4c292 
* stable:
  (chocolateyGH-405) Cache downloads by name and version
  (chocolateyGH-243) Add Proxy Support
  (chocolateyGH-243) Ensure NuGet Proxy Override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug
Projects
None yet
Milestone
0.9.9.9
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @timbrown5