Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chocolatey Installer - removing modules not loaded #442

Closed
rismoney opened this issue Oct 2, 2015 · 1 comment
Closed

Chocolatey Installer - removing modules not loaded #442

rismoney opened this issue Oct 2, 2015 · 1 comment
Assignees
@rismoney
Labels
5 - Released Improvement
Milestone
0.9.9.9

Comments

@rismoney
Copy link
Contributor

rismoney commented Oct 2, 2015

the chocolateyInstall script attempts to remove modules that are not necessarily loaded.
The current solution does a dirty -erroraction -silentlycontinue.

i am proposing putting a conditional to eliminate output within stderr.
will follow up with a PR.
rismoney added a commit to rismoney/choco that referenced this issue Oct 2, 2015
@rismoney
(chocolateyGH-442) add conditional to prevent removal of unloaded mod…
cbf158e 
…ules

this is part of a cleaning up content that might be contained
within stderr.
@ferventcoder ferventcoder added this to the 0.9.9.9 milestone Oct 2, 2015
@ferventcoder
Copy link
Member

@rismoney the conditional will probably need to be in the form of an environment variable.

@ferventcoder ferventcoder changed the title removing modules not loaded Chocolatey Installer - removing modules not loaded Oct 2, 2015
@rismoney rismoney mentioned this issue Oct 2, 2015
Closed
rismoney added a commit that referenced this issue Oct 2, 2015
@rismoney @ferventcoder
(GH-442) add conditional to prevent removal of unloaded modules
62dab72 
this is part of a cleaning up content that might be contained
within stderr.
ferventcoder added a commit that referenced this issue Oct 2, 2015
@ferventcoder
Merge branch 'module' into stable
8840209 
* module:
  (GH-442) add conditional to prevent removal of unloaded modules
ferventcoder added a commit that referenced this issue Oct 2, 2015
@ferventcoder
Merge branch 'stable'
f3254e7 
* stable:
  (GH-442) add conditional to prevent removal of unloaded modules
  (maint) Don't print chocolatey version every cmd
  (GH-444) Bootstrap - Write-Output over Write-Host

# Conflicts:
#	nuget/chocolatey/tools/chocolateysetup.psm1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rismoney rismoney

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.9.9.9
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @rismoney