Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISM "/All" argument in the wrong position. #480

Closed
jbuedel opened this issue Nov 16, 2015 · 3 comments

Comments

@jbuedel
Copy link
Contributor

commented Nov 16, 2015

TLDR: '/All/ argument to dism.exe needs to be the last argument.

Choco is attempting to run

"C:\Windows\System32\dism.exe" /Online /English /LogLevel=3 /NoRestart /All /Enable-Feature /FeatureName:MSMQ-Server'

but should run

"C:\Windows\System32\dism.exe" /Online /English /LogLevel=3 /NoRestart /Enable-Feature /FeatureName:MSMQ-Server' /All

I am using the beta to take advantage of the windowsfeatures source. When attempting to install MSMQ-Server I get the error below. This is what led me to find the bad parameter.

~\src [develop ≡ +1 ~0 -0 !]>choco install MSMQ-Server --source windowsfeatures
Chocolatey v0.9.10-beta1
Installing the following packages:
MSMQ-Server
By installing you accept licenses for the packages.
 [Windows Features] Deployment Image Servicing and Management tool
 [Windows Features] Version: 6.3.9600.17031
 [Windows Features] Image Version: 6.3.9600.17031
 [Windows Features] Error: 87
 [Windows Features] The all option is unknown.
 [Windows Features] For more information, refer to the help by running DISM.exe /?.
 [Windows Features] The DISM log file can be found at C:\Windows\Logs\DISM\dism.log

Chocolatey installed 0/1 package(s). 1 package(s) failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures:
 - MSMQ-Server
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

@jbuedel If you feel up to it, I'll take a PR on this one.

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

Target stable.

jbuedel added a commit to jbuedel/choco that referenced this issue Dec 1, 2015
ferventcoder added a commit that referenced this issue Dec 1, 2015
(GH-480) /All should be the final argument to dism.exe
@ferventcoder ferventcoder self-assigned this Dec 1, 2015
@ferventcoder ferventcoder added 3 - Done and removed 0 - Backlog labels Dec 1, 2015
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Dec 1, 2015

Thanks! This fix will be included in 0.9.10. Expect a release in December.

ferventcoder added a commit that referenced this issue Dec 10, 2015
* stable:
  (maint) Remove unused variable
  (maint) cleaning up warnings
  (build) update uc / ilmerge
  (GH-480) '/All' must be the last arg to dism.exe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.