Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions enhancements #588

Closed
ferventcoder opened this issue Jan 27, 2016 · 3 comments

Comments

@ferventcoder
Copy link
Member

commented Jan 27, 2016

  • Allow the package id to be either *.extension or *.extensions.
  • Name the extensions folder by the name of the package id, minus .extensions and .extension.
  • If the package has a folder extensions, only copy that folder, otherwise copy the enter package folder over to the extensions folder.

This provides backwards compatibility with the older method if the user doesn't have a package that has an extensions folder.

@ferventcoder

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

Not a breaking change, but it may not clean up an older extension.

@ferventcoder

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

Take it back, it's a breaking change if the users didn't create an extensions folder.

@ferventcoder

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

Of course we could handle that scenario as well.

@ferventcoder ferventcoder added 3 - Done and removed 0 - Backlog labels Jan 27, 2016
@ferventcoder ferventcoder changed the title Extensions should be added by only what is in the extensions folder and the name of the package Extensions enhancements Jan 27, 2016
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 27, 2016
Allow the package name to be either `*.extension` or `*.extensions`.

Name the extensions folder by the name of the package id, minus
`.extensions` and `.extension`.

If the package has a folder extensions, only copy that folder,
otherwise copy the enter package folder over to the extensions folder.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 27, 2016
* stable:
  (chocolateyGH-588) Extensions enhancements
ferventcoder added a commit that referenced this issue May 6, 2016
Look for and be able to upgrade/uninstall extensions that were
installed prior to 0.9.10 code, which removes the word ".extension"
from the extension folder name and only copies in the extensions folder
instead of the whole package.
ferventcoder added a commit that referenced this issue May 6, 2016
* stable:
  (doc) update CHANGELOG/nuspec
  (GH-724) Set Env Vars to empty should remove vars
  (doc) Update CHANGELOG/nuspec
  (GH-588) Manage extensions installed w/old method
  (GH-723) Fully qualify MsiExec
  (maint) use systemroot over windir
  (maint) spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.