Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start-ProcessAsAdmin - working directory should be from the location of the executable #937

Closed
ferventcoder opened this issue Aug 31, 2016 · 0 comments
Closed

Start-ProcessAsAdmin - working directory should be from the location of the executable #937

ferventcoder opened this issue Aug 31, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Customer Priority_HIGH
Milestone
0.10.1

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Aug 31, 2016 •
edited

When running an installer, the working directory should be from the directory of the executable. It appears to use Get-Location, so that should be fixed -

choco/src/chocolatey.resources/helpers/functions/Start-ChocolateyProcessAsAdmin.ps1

Line 189 in 634868f

$process.StartInfo.WorkingDirectory = Get-Location

@ferventcoder ferventcoder added this to the 0.10.1 milestone Aug 31, 2016
@ferventcoder ferventcoder self-assigned this Aug 31, 2016
ferventcoder added a commit that referenced this issue Sep 2, 2016
@ferventcoder
(GH-937) Externalize Working Directory
937f828 
Allow working directory to be specified, default to `Get-Location` when
a value is not specified.
ferventcoder added a commit that referenced this issue Sep 2, 2016
@ferventcoder
(GH-937) Installer Location as Working Directory
5374991 
Install-ChocolateyInstallPackage should set the working directory to
the location of the installer, or at least attempt to, falling back to
`Get-Location` when it is unable to set the directory appropriately.
That should be passed through to `Start-ChocolateyProcessAsAdmin`
`$WorkingDirectory` parameter.
ferventcoder added a commit that referenced this issue Sep 2, 2016
@ferventcoder
Merge branch 'stable'
b077c3a 
* stable:
  (maint) Log Option Parse Error w/Converted Message
  (doc) Log Silent Args that Were Overridden
  (GH-937) Installer Location as Working Directory
  (GH-937) Externalize Working Directory
  (GH-941) Install-ChocolateyInstallPackage - Alias $fileFullPath
  (GH-458) Support TLS v1.2
ferventcoder added a commit that referenced this issue Sep 12, 2016
@ferventcoder
(GH-937) Working directory should be in debug log
3139d06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Customer Priority_HIGH
Projects
None yet
Milestone
0.10.1
Development

No branches or pull requests
2 participants
@ferventcoder @gep13