Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure PowerShell functions have parameter name parity #941

Closed
2 tasks done
ferventcoder opened this issue Sep 1, 2016 · 0 comments
Closed
2 tasks done

Ensure PowerShell functions have parameter name parity #941

ferventcoder opened this issue Sep 1, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.10.1

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Sep 1, 2016 •
edited

  • Alias $file with Get-ChocolateyUnzip
  • Alias $url64 with Get-ChocolateyWebFile

Get-ChocolateyUnzip uses $FileFullPath, which is a well-defined name, doesn't match the parameter used in other methods. Add an alias for $File to match.

Everywhere that $url64bit is found, it should alias $url64 for parity.
@ferventcoder ferventcoder added this to the 0.10.1 milestone Sep 1, 2016
@ferventcoder ferventcoder self-assigned this Sep 1, 2016
@ferventcoder ferventcoder changed the title Alias "$File" with Get-ChocolateyUnzip Ensure PowerShell functions have parameter name parity Sep 1, 2016
ferventcoder added a commit to ferventcoder/choco that referenced this issue Sep 1, 2016
@ferventcoder
(chocolateyGH-941) Get-ChocolateyUnzip aliases File for parity
c0f0c41 
Get-ChocolateyUnzip uses `$FileFullPath`, which doesn't
match the parameter used in other functions. Add an alias for `$File` to
provide parity.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Sep 1, 2016
@ferventcoder
(chocolateyGH-941) Alias $url64 with Get-ChocolateyWebFile
cf03c93 
Everywhere that `$url64bit` is found, it should alias url64.
ferventcoder added a commit that referenced this issue Sep 1, 2016
@ferventcoder
Merge branch 'stable'
edf4994 
* stable:
  (maint) formatting
  (maint) download would come next to new
  (doc) Provide SHA256 recommendation
  (GH-941) Alias `$url64` with Get-ChocolateyWebFile
  (GH-941) Get-ChocolateyUnzip aliases File for parity
  (GH-940) Log Native  Installer Output to Verbose
  (maint) Template - add checksumtypes / set sha256
ferventcoder added a commit that referenced this issue Sep 2, 2016
@ferventcoder
(GH-941) Install-ChocolateyInstallPackage - Alias $fileFullPath
bf0d88d
ferventcoder added a commit that referenced this issue Sep 2, 2016
@ferventcoder
Merge branch 'stable'
b077c3a 
* stable:
  (maint) Log Option Parse Error w/Converted Message
  (doc) Log Silent Args that Were Overridden
  (GH-937) Installer Location as Working Directory
  (GH-937) Externalize Working Directory
  (GH-941) Install-ChocolateyInstallPackage - Alias $fileFullPath
  (GH-458) Support TLS v1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.10.1
Development

No branches or pull requests
2 participants
@ferventcoder @gep13