(#2412) Change importing of Licensed extension to output warning #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
force-pushed
the
2412-Faling-to-load-all-helper-cmdlets-when-extensions-fails-to-load
branch
from
874c796
to
15a55aa
Compare
This commit updates the chocolateyInstaller module to not output an error when failing to load the Chocolatey Licensed Extension which would prevent all helper cmdlets in FOSS being exported. Instead the importing have been wrapped inside a try/catch block and writes out a Warning that includes the reason the importing failed.
gep13
force-pushed
the
2412-Faling-to-load-all-helper-cmdlets-when-extensions-fails-to-load
branch
from
15a55aa
to
a9b0ea9
Compare
|
@AdmiringWorm thank you for getting this fixed up! |
AdmiringWorm
deleted the
2412-Faling-to-load-all-helper-cmdlets-when-extensions-fails-to-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Version 0.11.1 introduced changes to how the Chocolatey Licensed Extension was loaded, and changed any failures of loading the extension away from being a warning to be a Error instead.
This pull request updates the importing to instead re-introduce the failure as a warning by wrapping the imports inside a try/catch block instead.
Motivation and Context
To revert a breaking change that had been introduced in v0.11.1, and to keep it backwards compatible.
What Have I Done To Test This
This have been tested with following scenarios in mind.
chocolateyInstaller.psm1script, which did not use to write out an error.Get-ChocolateyWebFile, and make sure any monkey patch is not already available. Try updating the package.Change Types Made
Related Issue
Change Checklist