(#2345) Do not add trailing space to arguments #2950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
args-extra-space
branch
2 times, most recently
from
3706cfa
to
b765bfd
Compare
TheCakeIsNaOH
force-pushed
the
args-extra-space
branch
from
b765bfd
to
a8cc9a5
Compare
TheCakeIsNaOH
force-pushed
the
args-extra-space
branch
from
a8cc9a5
to
9101a60
Compare
TheCakeIsNaOH
force-pushed
the
args-extra-space
branch
from
9101a60
to
fa31b35
Compare
TheCakeIsNaOH
force-pushed
the
args-extra-space
branch
from
fa31b35
to
6bb88e6
Compare
This prevents the addition of a trailing space after silent arguments in Install-ChocolateyInstallPackage when there are no additional arguments.
TheCakeIsNaOH
force-pushed
the
args-extra-space
branch
from
6bb88e6
to
65990bb
Compare
|
@TheCakeIsNaOH thank you for taking the time to submit this PR, and apologies for the time it has taken to come back to you about it. In the end, there were 3 PR's that attempted to address this problem, and based on a review by @corbob we have opted to move forward with a different PR: As such, I am going to go ahead and close out this PR. Thank you again for raising this PR, and bringing additional focus on the underlying problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This prevents the addition of a trailing space after silent arguments in
Install-ChocolateyInstallPackagewhen there are no additional arguments.Motivation and Context
See #2345
Testing
TODO
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #2345