Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2886)(#2761) Improve remembered arguments handling #3003

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

(#2886)(#2761) Improve remembered arguments handling #3003

wants to merge 3 commits into from

Commits on Apr 28, 2024

  1. (chocolatey#508) Make package id comparisons case insensitive 

    This helps ensure that package IDs are handled in a case
insensitive manner.
    @TheCakeIsNaOH
    TheCakeIsNaOH committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    edd1f23 View commit details
    Browse the repository at this point in the history

  2. (chocolatey#2761) Allow overriding remembered arguments 

    This allows overriding of remembered package parameters, install
arguments, cache location and execution timeout during upgrade.
So a user can pass in different package parameters or arguments
without having to completely reinstall the package or turn off
remembered arguments.

Switch arguments cannot be checked, because the lack of a switch
normally would mean that they are just relying on the remembered args
to remember it, so there is no way to determine if an override of the
remembered args is appropriate.
    @TheCakeIsNaOH
    TheCakeIsNaOH committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2c37c9a View commit details
    Browse the repository at this point in the history

  3. (chocolatey#2886) Switch remembered args to only change local configu… 

    …ration

This adds a new method, GetPackageConfigFromRememberedArguments which
is similar to SetConfigFromRememberedArguments, but operates using a
different method. First, a OptionSet is set up, so only the config
that is passed in is modified, instead of the config that the global
options parser was set with with. Second, it returns the modified
configuration instead of the original configuration, because it is the
local configuration being modified. Third, it has a more general name
and changes log messages to be more general, so it later can more
easily be reused for uninstall and export.

This change fixes remembered arguments when Chocolatey is used as a
library, like in ChocolateyGUI, where the config that is passed to
the install_run method is not necessarily the same config object that
was used to set up the global argument parser.

The downside of using a new commandline parser is that it opens up the
possibility of drift between the upgrade/global arguments and this
added parser. However, this is not an issue because the format of the
saved arguments is known, and any added arguments there would not work
without being added here as well, which would be picked up during
development.
    @TheCakeIsNaOH
    TheCakeIsNaOH committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    85ab916 View commit details
    Browse the repository at this point in the history