(GH-50) Specs to verify Chocolatey Package Dependency

src/chocolatey.package.validator.tests/chocolatey.package.validator.tests.csproj

@@ -42,6 +42,10 @@
     <Reference Include="Moq">
       <HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
     </Reference>
+    <Reference Include="NuGet.Core, Version=1.6.30117.9648, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
+      <SpecificVersion>False</SpecificVersion>
+      <HintPath>..\..\lib\Nuget-Chocolatey\NuGet.Core.dll</HintPath>
+    </Reference>
     <Reference Include="nunit.framework">
       <HintPath>..\packages\NUnit.2.5.10.11092\lib\nunit.framework.dll</HintPath>
     </Reference>
@@ -78,6 +82,7 @@
     <Compile Include="..\SolutionVersion.cs">
       <Link>Properties\SolutionVersion.cs</Link>
     </Compile>
+    <Compile Include="infrastructure.app\IncludesChocolateyDependencyNoteSpecs.cs" />
     <Compile Include="infrastructure\events\context\FakeMessage.cs" />
     <Compile Include="infrastructure\events\context\FakeSubscriber.cs" />
     <Compile Include="infrastructure\events\EventSubscriptionManagerSpecs.cs" />

src/chocolatey.package.validator.tests/infrastructure.app/IncludesChocolateyDependencyNoteSpecs.cs

@@ -0,0 +1,52 @@
+namespace chocolatey.package.validator.tests.infrastructure.app
+{
+    using System.Collections.Generic;
+    using System.Runtime.Versioning;
+    using chocolatey.package.validator.infrastructure.app.rules;
+    using NuGet;
+    using Moq;
+    using Should;
+
+    public abstract class IncludesChocolateyDependencyNoteSpecsBase : TinySpec
+    {
+        protected IncludesChocolateyDependencyNote note;
+        protected Mock<IPackage> packageWithoutChocolateyDependency = new Mock<IPackage>();
+        protected Mock<IPackage> packageWithChocolateyDependency = new Mock<IPackage>();
+
+        public override void Context()
+        {
+            note = new IncludesChocolateyDependencyNote();
+            var fiddlerPackageDependency = new PackageDependency("fiddler");
+            var chocolateyPackageDependency = new PackageDependency("chocolatey");
+            var packageDependenciesWithoutChocolatey = new List<PackageDependency> { fiddlerPackageDependency };
+            var packageDependenciesWithChocolatey = new List<PackageDependency> { fiddlerPackageDependency, chocolateyPackageDependency };
+            var dependencySetWithoutChocolatey = new PackageDependencySet(new FrameworkName(".NETFramework, Version = 4.0"), packageDependenciesWithoutChocolatey);
+            var dependencySetWithChocolatey = new PackageDependencySet(new FrameworkName(".NETFramework, Version = 4.0"), packageDependenciesWithChocolatey);
+            var dependencySetsWithoutChocolatey = new List<PackageDependencySet> { dependencySetWithoutChocolatey };
+            var dependencySetsWithChocolatey = new List<PackageDependencySet> { dependencySetWithChocolatey };
+            packageWithoutChocolateyDependency.Setup(p => p.DependencySets).Returns(dependencySetsWithoutChocolatey);
+            packageWithChocolateyDependency.Setup(p => p.DependencySets).Returns(dependencySetsWithChocolatey);
+        }
+    }
+
+    public class when_inspecting_dependencies : IncludesChocolateyDependencyNoteSpecsBase
+    {
+        private string result;
+
+        public override void Because()
+        {
+        }
+
+        [Fact]
+        public void should_return_false_with_chocolatey_as_a_dependency()
+        {
+            note.inspect_dependencies_for_chocolatey(packageWithChocolateyDependency.Object).ShouldBeFalse();
+        }
+
+        [Fact]
+        public void should_return_true_with_chocolatey_not_as_a_dependency()
+        {
+            note.inspect_dependencies_for_chocolatey(packageWithoutChocolateyDependency.Object).ShouldBeTrue();
+        }
+    }
+}

src/chocolatey.package.validator/infrastructure.app/rules/IncludesChocolateyDependencyNote.cs

@@ -23,9 +23,14 @@ public class IncludesChocolateyDependencyNote : BasePackageRule
     {
         public override string ValidationFailureMessage { get { return "Package takes a dependency on Chocolatey, which should only be required if package uses a specific Chocolatey feature.  Please see [wiki article](https://github.com/chocolatey/package-validator/wiki/ChocolateyDependency) for further information and guidance."; } }
 
-        protected override PackageValidationOutput is_valid(IPackage package)
+        public bool inspect_dependencies_for_chocolatey(IPackage package)
         {
             return package.DependencySets.All(dependencySet => dependencySet.Dependencies.All(dependency => dependency.Id.ToLower() != "chocolatey"));
         }
+
+        protected override PackageValidationOutput is_valid(IPackage package)
+        {
+            return inspect_dependencies_for_chocolatey(package);
+        }
     }
 }