Try closing reporter in test for windows fix #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR attempts to fix the issue raised in choderalab#527. From what I can tell, the tests where this is thrown always fails exactly at the same point. This PR closes the reporter file formally before the failing line occurs, so hopefully this will correctly allow Window's memory to release the file.
|
Awesome, thanks! If this fixes the issue with the windows tests, I'll re-enable them as a requirement for merging + get this into the next bug fix release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix the issue raised in #527. From what I can tell,
the tests where this is thrown always fails exactly at the same point.
This PR closes the reporter file formally before the failing line
occurs, so hopefully this will correctly allow Window's memory to
release the file.
Todos
Status