Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real time analysis dynamic naming from reporter #565

Merged
merged 3 commits into from Apr 8, 2022

Conversation

ijpulidos
Copy link
Contributor

Description

Fixes naming convention for new real time analysis yaml file. It uses the reporter filename as a prefix, dynamically. Solves #564

Todos

  • Implement feature / fix bug

Status

  • Ready to go

@ijpulidos ijpulidos requested a review from jchodera March 31, 2022 21:07
@mikemhenry
Copy link
Contributor

One quick question, do we want to do anything if the file exits already? I feel like there is some flag to overwrite files or not and I'm wondering if we should respect that?

@ijpulidos
Copy link
Contributor Author

One quick question, do we want to do anything if the file exits already? I feel like there is some flag to overwrite files or not and I'm wondering if we should respect that?

Right now it's overwriting by default. I'm not entirely sure there's a flag for overwriting.I remember it always complaining about the .nc file existing and refusing to overwrite in that case, here. For this new yaml file, the default behavior now is to overwrite, and this was agreed upon in a conversation with @jchodera

@jchodera jchodera added this to the 0.21.3 milestone Apr 4, 2022
Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget to update the changelog!

@ijpulidos ijpulidos merged commit 2ca4be3 into main Apr 8, 2022
@ijpulidos ijpulidos deleted the fix-realtime-analysis-file-naming branch April 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants