backwards deserialization compatibility #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should work, the warning is good. A future TODO could be to make sure that error doesn't get raised in our serialization tests, and have a test where we assert this error gets raised, but this is good for now. |
mikemhenry
approved these changes
Apr 4, 2023
|
I think we should change the changelog to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This catches a
KeyErrorwhen deserializing which prevents raising an error when deserializing objects from previous versions (0.21.4 or lower). It does so by showing a warning to the user.Resolves #618
Todos
Status
Changelog message