Fix NaN-catching text in MultiStateSampler #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemhenry
approved these changes
Apr 18, 2023
|
Nice catch! This might actually solve some of the stability issues some users been seeing when minimizing. Thanks! |
|
Would this one solve #686 ? |
|
No; that was caught as a follow-up to this (we were seeing 100% failures at minimization). There's a more fundamental issue in the FIRE minimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're getting errors in OpenFE during minimization of the multistate sampler. This appears to be because a handler for NaN in the FIRE minimizer was not updated to match OpenMM's changed error message. (I note that other lines seem to have updated). See OpenFreeEnergy/openfe#253 (comment) and following.
Todos
Status
Changelog message