Yujian/home view tag list #104
Conversation
hooked up tagQuery update
web/src/views/Home.tsx
Outdated
| </div> | ||
| <button type='button' onClick={() => console.log(tagQuery.map((tag) => tag.id))}>check tag</button> | ||
| <button type='button' onClick={() => scroll(-200)}> scroll left </button> | ||
| <button type='button' onClick={() => scroll(200)}> scroll right </button> |
There was a problem hiding this comment.
Clicking on tags functions as intended. Good stuff. I just noticed a few things with usability and found out it could do with the layout.
Clicking these buttons also clicked the cards below. This may be unintentional.
Might wish to try this separation to aid the browser sort the components a la Box Model. And also the ordering of buttons allows left to right arrangement (unless we would use grid-areas to make it left-right independent)
There was a problem hiding this comment.
Thanks for the feedback. I will make changes to the button position so that they are placed on either side of the tag list. As for the first issue, I think I will tackle that on the visual styling issue #56
oh as in you think the tagList should always stay at the top of the home view even when we scroll down on the cards section? |
yeah i was under the impression that that was the decision being made. |
I'm not too sure, but regardless I think I want leave this to the visual styling issue #56 |
there's also the extremely fancy way of, letting the taglist appear whenever user scroll down. |
I like the way you think, this will be a worthy challenge once the fundamentals of the visual styles are all set |
added tag list view in home with scrolling function, along with tagQuery consumption to filter the cards.
closes #85 and #86