Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walter/tag picker #105

Merged
merged 11 commits into from
Sep 27, 2021
Merged

Walter/tag picker #105

merged 11 commits into from
Sep 27, 2021

Conversation

waltervan00
Copy link
Collaborator

Closes #84 .

To test the ui, please spin up a local server and test the ui.

@waltervan00 waltervan00 self-assigned this Sep 24, 2021
@waltervan00 waltervan00 added the enhancement New feature or request label Sep 24, 2021
@waltervan00 waltervan00 added this to Sprint 2 in Product backlog via automation Sep 24, 2021
@waltervan00 waltervan00 added this to In progress in Sprint 2 via automation Sep 24, 2021
@waltervan00 waltervan00 added this to the Sprint 2 milestone Sep 24, 2021
Sprint 2 automation moved this from In progress to In review Sep 25, 2021
Copy link
Collaborator

@oldbugo oldbugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have spotted two things that I think we may need to consider.

The first is in the cardDetailView, the user cannot add/edit the tags before edit mode is engaged.
image
In this view, the "X" button to disassociate the tags should be present when the mouse is hovering over it. And the add/edit tag button should be appended at the very end.
I think it is better to have the editing tag functions separate from the editing cards.

The second thing I found was that in tagPicker, the tag will disappear from the list of tags once you have associated it with the card. With this implementation, the user won't be able to edit the tags (e.g. change colour) unless they first disassociated.

Other than that, very nicely done.

@oldbugo
Copy link
Collaborator

oldbugo commented Sep 25, 2021

Another issue I encountered is when I go tag picker --> associated any tag/s --> edit tag --> click out to close tag edit, the state will be reverted back to before I associated any tags.

@chomosuke
Copy link
Owner

Another issue I encountered is when I go tag picker --> associated any tag/s --> edit tag --> click out to close tag edit, the state will be reverted back to before I associated any tags.

a more general description would be any edit to any tags would override state of cardDetail.

I believe #108 fixes this.

@waltervan00
Copy link
Collaborator Author

waltervan00 commented Sep 25, 2021

Another issue I encountered is when I go tag picker --> associated any tag/s --> edit tag --> click out to close tag edit, the state will be reverted back to before I associated any tags.

I'll be testing this shortly using #108

Copy link
Owner

@chomosuke chomosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag's components should have their own sub folder like cardDetails' components do imo.

other than that lgtm

@oldbugo
Copy link
Collaborator

oldbugo commented Sep 25, 2021

Another issue I encountered is when I go tag picker --> associated any tag/s --> edit tag --> click out to close tag edit, the state will be reverted back to before I associated any tags.

I'll be testing this shortly using #108

yes sir

Copy link
Collaborator

@shangzhel shangzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly code style changes.

web/src/components/tagSelector/TagEditor.tsx Show resolved Hide resolved
web/src/components/tagSelector/TagEditor.tsx Outdated Show resolved Hide resolved
web/src/components/tagSelector/TagPicker.tsx Outdated Show resolved Hide resolved
web/src/components/tagSelector/TagPicker.tsx Show resolved Hide resolved
web/src/components/tagSelector/TagPicker.tsx Outdated Show resolved Hide resolved
web/src/components/tagSelector/TagWrapper.tsx Outdated Show resolved Hide resolved
@waltervan00 waltervan00 merged commit 7a8679e into master Sep 27, 2021
Sprint 2 automation moved this from In review to Done Sep 27, 2021
Product backlog automation moved this from Sprint 2 to Sprint 2 Done Sep 27, 2021
@waltervan00 waltervan00 deleted the walter/tagPicker branch September 27, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Product backlog
  
Sprint 2 Done
Sprint 2
  
Done
Development

Successfully merging this pull request may close these issues.

Create tag picker component
4 participants