Pep/search box tag query support #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pep1032314
requested review from
chomosuke,
shangzhel,
oldbugo and
waltervan00
|
|
waltervan00
approved these changes
Sep 25, 2021
oldbugo
reviewed
Sep 25, 2021
yep doing it now |
oldbugo
approved these changes
Sep 25, 2021
shangzhel
requested changes
Sep 25, 2021
web/src/components/SearchBox.tsx
Outdated
|
|
||
| const clearTagButton = () => { | ||
| if (context.tagQuery.length === 0) { | ||
| return (<></>); |
There was a problem hiding this comment.
Return null if there is no element.
Suggested change
| return (<></>); | |
| return null; |
web/src/components/SearchBox.tsx
Outdated
| @@ -14,11 +47,30 @@ export const SearchBox: React.VoidFunctionComponent = () => { | |||
| }); | |||
| }; | |||
|
|
|||
| const removeTagFromQuery = (tag:ITag) => ( | |||
There was a problem hiding this comment.
Whitespace.
Suggested change
| const removeTagFromQuery = (tag:ITag) => ( | |
| const removeTagFromQuery = (tag: ITag) => ( |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show tags in the query next to the search bar.
Remove tag from query when the "X" button is pressed.
close #87