-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Richard/some card detail style #122
Conversation
This reverts commit 5864a18. Can not get jest to work with es2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there are three issues apparent to me.
The first is that the button are black instead of white, I hope this is a simple fix.
The second is that attribute fields are missing text wrap
The third issue, which can be very tricky, is the padding/margin around the texts
So you can see that when we give it the white box in editing mode the position of the text changes a little. This problem exists for every instance of where we have it implemented, so for the user the whole screen kinda jitter a little.
I suggest you try to make invisible boxes for when it's not in editing mode (like what I have in figma), so the sizes and relative margins and padding don't change. Or you can try something else, I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the button color. The other issue we can fix at a later date.
be6b241
to
bd82d23
Compare
closes #113.