Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richard/some card detail style #122

Merged
merged 27 commits into from
Oct 3, 2021
Merged

Conversation

chomosuke
Copy link
Owner

@chomosuke chomosuke commented Sep 29, 2021

  • Close Button
  • Image
  • CardFields
  • Note box
  • CardDetailAction
    • Expand Button
    • Edit Button
    • Commit Button
    • Cancel Button
    • Delete Button

closes #113.

@chomosuke chomosuke requested review from shangzhel and oldbugo and removed request for shangzhel September 29, 2021 08:57
@chomosuke chomosuke self-assigned this Sep 29, 2021
@chomosuke chomosuke added the enhancement New feature or request label Sep 29, 2021
@chomosuke chomosuke added this to In progress in Sprint 2 via automation Sep 29, 2021
@chomosuke chomosuke added this to Sprint 2 in Product backlog via automation Sep 29, 2021
@chomosuke chomosuke added this to the Sprint 2 milestone Sep 29, 2021
Copy link
Collaborator

@oldbugo oldbugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are three issues apparent to me.

The first is that the button are black instead of white, I hope this is a simple fix.

The second is that attribute fields are missing text wrap
image

The third issue, which can be very tricky, is the padding/margin around the texts
image
image
So you can see that when we give it the white box in editing mode the position of the text changes a little. This problem exists for every instance of where we have it implemented, so for the user the whole screen kinda jitter a little.
image
I suggest you try to make invisible boxes for when it's not in editing mode (like what I have in figma), so the sizes and relative margins and padding don't change. Or you can try something else, I don't know.

Sprint 2 automation moved this from In progress to In review Sep 29, 2021
Copy link
Collaborator

@oldbugo oldbugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the button color. The other issue we can fix at a later date.

@waltervan00 waltervan00 removed their request for review September 30, 2021 09:03
@chomosuke chomosuke removed the request for review from shangzhel September 30, 2021 11:23
@chomosuke chomosuke merged commit 66d8875 into master Oct 3, 2021
Sprint 2 automation moved this from In review to Done Oct 3, 2021
Product backlog automation moved this from Sprint 2 to Sprint 2 Done Oct 3, 2021
@chomosuke chomosuke deleted the richard/someCardDetailStyle branch October 3, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Product backlog
  
Sprint 2 Done
Sprint 2
  
Done
Development

Successfully merging this pull request may close these issues.

Style some card detail elements
3 participants