Yujian/home view style #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes were made on the fly: the first is the gap between the card is now more dynamic; the second is that the focus decorator is now using shadow.
focusDecorator
8 tasks
space at the bottom of the page.
shangzhel
requested changes
Oct 1, 2021
wrapped long lines to be more legible.
and clicking of tagButton to allow for contrast.
had its corner.
shangzhel
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some design changes were made on the fly. First is the horizontal gap between each card component is now dynamic based on how much space is available. The second is the focusDecorator is now using shadows to highlight which card is selected rather than a border.
Let me know if you think these changes should be reconsidered.
closes #112