Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yujian/log in style #125

Merged
merged 4 commits into from
Oct 2, 2021
Merged

Yujian/log in style #125

merged 4 commits into from
Oct 2, 2021

Conversation

oldbugo
Copy link
Collaborator

@oldbugo oldbugo commented Sep 30, 2021

Basic styling to login and register view. I couldn't make it look exactly like the style guide because changes to Fluent UI is more trouble than its worth. And I think the end result is fine enough.

closes #115

@oldbugo oldbugo added the enhancement New feature or request label Sep 30, 2021
@oldbugo oldbugo added this to the Sprint 2 milestone Sep 30, 2021
@oldbugo oldbugo self-assigned this Sep 30, 2021
@oldbugo oldbugo added this to In progress in Sprint 2 via automation Sep 30, 2021
@oldbugo oldbugo added this to Sprint 2 in Product backlog via automation Sep 30, 2021
@shangzhel shangzhel moved this from In progress to In review in Sprint 2 Sep 30, 2021
web/src/views/Login.tsx Outdated Show resolved Hide resolved
web/src/views/Login.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@waltervan00 waltervan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But currently the application does not scroll on small window sizes, is this going to be addressed in #119 ?

@oldbugo
Copy link
Collaborator Author

oldbugo commented Oct 2, 2021

Looks good. But currently the application does not scroll on small window sizes, is this going to be addressed in #119 ?

Unfortunately, no.
I think this would be something to implement if we ever get to implementing the mobile viewport,

@oldbugo oldbugo requested a review from shangzhel October 2, 2021 02:45
@oldbugo oldbugo merged commit e647d64 into master Oct 2, 2021
Sprint 2 automation moved this from In review to Done Oct 2, 2021
Product backlog automation moved this from Sprint 2 to Sprint 2 Done Oct 2, 2021
@oldbugo oldbugo deleted the yujian/logIn-Style branch October 2, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Product backlog
  
Sprint 2 Done
Sprint 2
  
Done
Development

Successfully merging this pull request may close these issues.

Style login view
3 participants