Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richard/fix search auto scroll #126

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Conversation

chomosuke
Copy link
Owner

when a card div can no longer be found, it's unlocked and the cardSection is scroll back to the top.

autoScroll now uses a ref instead of states mostly because yujian requested for home to not be rerendered randomly, but also because it's more correct because it's information unrelated to the render.

@chomosuke chomosuke added the enhancement New feature or request label Sep 30, 2021
@chomosuke chomosuke added this to the Sprint 2 milestone Sep 30, 2021
@chomosuke chomosuke self-assigned this Sep 30, 2021
@chomosuke chomosuke added this to In progress in Sprint 2 via automation Sep 30, 2021
@chomosuke chomosuke added this to Sprint 2 in Product backlog via automation Sep 30, 2021
@chomosuke chomosuke added bug Something isn't working and removed enhancement New feature or request labels Sep 30, 2021
Copy link
Collaborator

@shangzhel shangzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with it, and I trust that you had tested this thoroughly before PRing.

@chomosuke chomosuke merged commit 4a62611 into master Sep 30, 2021
Sprint 2 automation moved this from In progress to Done Sep 30, 2021
Product backlog automation moved this from Sprint 2 to Sprint 2 Done Sep 30, 2021
@chomosuke chomosuke deleted the richard/fixSearchAutoScroll branch September 30, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Product backlog
  
Sprint 2 Done
Sprint 2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants