Style header #127
Style header #127
Conversation
- Move components that are exclusively used by the Header into the src/components/Header directory.
shangzhel
requested review from
chomosuke,
oldbugo,
waltervan00 and
pep1032314
There was a problem hiding this comment.
Two minor style changes, and a bug I've encountered that we may want to fix.
For the minor styles, the first is that the logo I think is better off to be all caps, but that's just a personal preference thing. The second is to have a little bit more right margin for the user-icon (see pic below, the exact number of and implementation is up to you of course)
Now for the bug, see the picture below.
The way I can recreate this bug is by:
render page in smaller window --> click on user-icon to bring up dropdown menu --> resize the window to make the viewport bigger i.e. maximize window.
Now, if I click the user-icon again the drop down would pop up in where it shouldn't. This is tested on Chrome.
Otherwise, very nicely done. Thank you for your work.
I chose 14px because it is half of the gap between the two buttons, starting with 56px in your style guide then scaled down to 28px to adjust for high DPI. This is what it looks like now |
shangzhel
requested review from
oldbugo
and removed request for
chomosuke,
waltervan00 and
pep1032314
Logged out
Logged in
Closes Style header #116
The style guide will needs some adjustments to match the adjusted component metrics.
Future: modify the theme defaults with the new metrics.
Future: fix layout issue when screen space is insufficient