-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walter/mongo db ci #151
Merged
Merged
Walter/mongo db ci #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn 410 on deleting non-owned carded
shangzhel
approved these changes
Oct 18, 2021
chomosuke
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we can run all tests with 1 command.
But, this project is coming to an end, so that does not really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
Endpoint changes:
DELETE /api/card now issues 410 when attempting to delete someone else's card id.
Ci changes:
Script included to spool up instance of server and mongodb on ci environment for calling api tests to self.
To Run locally: the following shell script is provided, runnable in Ubuntu
Integration tests automatically default to the values shown here (hard coded in tests but first accept environmental values, if any). You'll need to start a mongodb instance at port 27017 (or what's configured to DB_TESTING_PATH) and establish a server using the save database path used for the mongodb, with port 8080.