Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walter/mongo db ci #151

Merged
merged 22 commits into from
Oct 21, 2021
Merged

Walter/mongo db ci #151

merged 22 commits into from
Oct 21, 2021

Conversation

waltervan00
Copy link
Collaborator

@waltervan00 waltervan00 commented Oct 12, 2021

Closes #64
Endpoint changes:
DELETE /api/card now issues 410 when attempting to delete someone else's card id.

Ci changes:
Script included to spool up instance of server and mongodb on ci environment for calling api tests to self.

To Run locally: the following shell script is provided, runnable in Ubuntu
Integration tests automatically default to the values shown here (hard coded in tests but first accept environmental values, if any). You'll need to start a mongodb instance at port 27017 (or what's configured to DB_TESTING_PATH) and establish a server using the save database path used for the mongodb, with port 8080.

export DB_TESTING_PATH="mongodb://localhost:27017/integrationTests"
export SERVER_PORT="8080"
hash=$(node -p "crypto.randomBytes(32).toString('base64')")
npm start -- -s $hash -c $DB_TESTING_PATH -p $SERVER_PORT

@waltervan00 waltervan00 added the documentation Improvements or additions to documentation label Oct 12, 2021
@waltervan00 waltervan00 added this to the Sprint 3 milestone Oct 12, 2021
@waltervan00 waltervan00 self-assigned this Oct 12, 2021
@waltervan00 waltervan00 added this to Sprint 3 in Product backlog via automation Oct 12, 2021
@shangzhel shangzhel added this to In progress in Sprint 3 via automation Oct 15, 2021
Sprint 3 automation moved this from In progress to Reviewer approved Oct 18, 2021
Copy link
Owner

@chomosuke chomosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we can run all tests with 1 command.

But, this project is coming to an end, so that does not really matter.

@waltervan00 waltervan00 merged commit 8895611 into master Oct 21, 2021
Sprint 3 automation moved this from Reviewer approved to Done Oct 21, 2021
Product backlog automation moved this from Sprint 3 to Sprint 3 Done Oct 21, 2021
@waltervan00 waltervan00 deleted the walter/mongoDB-CI branch October 21, 2021 05:03
@waltervan00 waltervan00 restored the walter/mongoDB-CI branch October 21, 2021 05:03
@waltervan00 waltervan00 deleted the walter/mongoDB-CI branch October 25, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Product backlog
  
Sprint 3 Done
Development

Successfully merging this pull request may close these issues.

Write integration tests for the server
3 participants