Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Richard/acceptanceTests #153

Merged
merged 45 commits into from
Oct 20, 2021
Merged

Richard/acceptanceTests #153

merged 45 commits into from
Oct 20, 2021

Conversation

chomosuke
Copy link
Owner

Some optional step I did not do. If @waltervan00 think any of them are important to do just tell me or branch out from this branch.

Shang Zhe Lee and others added 30 commits October 8, 2021 20:29
Add Jest acceptance test config.
1606d9b
Add acceptance test scaffolding.
11f72d5
Add acceptance test AC01: Successful registration.
4c0eea6
Lift API route interception.
73db75b
Refactor acceptance test route interceptor.
ef80016 
Add support for multiple API route pattern handlers.
Run acceptance tests on root package test script.
f1e4678
Run acceptance tests in parallel.
f252608
Use a real server instance to run acceptance tests against.
0ba00cb
Detach server process in acceptance test.
53fb25d
Use http.request because Node.js does not support fetch.
4ed2ef6
Increase CI server port.
349403d
Work around Taiko.
63c2dba
Add AC02: Failed registration using non-unique username.
f547f04
Use insecure cookies when running automated tests.
c7997ea
Add AC03: Successful login.
d2c0e3d
Add AC04: Failed login with incorrect credentials.
91f1572
@chomosuke
Merge branch 'master' of github.com:chomosuke/IT-PROJECT-PorkBellyPro…
b3f2d69 
… into richard/acceptance-tests
@chomosuke
npm audit
2aa27b9
@chomosuke
default SERVER_PORT env variable to 80 for convinience of local run
c23864b
@chomosuke
successfully running taiko locally
00f5e91
@chomosuke
extracted precondition from ac test 1-4
38f7d59
@chomosuke
ac06
7c270b9
@chomosuke
ac05
6d26387
@chomosuke
refactor of ac06 and ac06, tested upload image for ac06
5cf1dc2
@chomosuke
extracted precondition to it's own file so tests don't import each other
056e035
@chomosuke
ac07
b738f50
@chomosuke
ac08
20a780e
@chomosuke
made ac08 faster by checking existence instead of lack of existence
f3f5156
@chomosuke
ac09
b91fe8f
@chomosuke
ignore .helpers in __acceptance__ test and accept all else
ac23deb
@chomosuke chomosuke added the enhancement New feature or request label Oct 19, 2021
@chomosuke chomosuke added this to the Sprint 3 milestone Oct 19, 2021
@chomosuke chomosuke self-assigned this Oct 19, 2021
@chomosuke chomosuke added this to Sprint 3 in Product backlog via automation Oct 19, 2021
@chomosuke chomosuke added this to In progress in Sprint 3 via automation Oct 19, 2021
Sprint 3 automation moved this from In progress to Reviewer approved Oct 20, 2021
shangzhel
shangzhel approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@shangzhel shangzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am technically opposed to the usage of ids in the React elements because it means the component becomes unsuitable for reuse. However our project is complete and where will not be a case for us to reuse the components so it is a non-issue. Approved.

@chomosuke
Copy link
Owner Author

I am technically opposed to the usage of ids in the React elements because it means the component becomes unsuitable for reuse. However our project is complete and where will not be a case for us to reuse the components so it is a non-issue. Approved.

Out of curiosity, do you think using the css selector with class name as I've done before 68b3037 would be better?

@chomosuke chomosuke merged commit 93c91a6 into master Oct 20, 2021
Sprint 3 automation moved this from Reviewer approved to Done Oct 20, 2021
Product backlog automation moved this from Sprint 3 to Sprint 3 Done Oct 20, 2021
@chomosuke chomosuke deleted the richard/acceptance-tests branch October 20, 2021 05:31
@shangzhel
Copy link
Collaborator

Generic selectors like button and text that rely on user-visible elements would be preferred over selecting by implementation details like class names and ids. That way the acceptance tests would execute as if it were a human controlling the browser by observing and interacting with visible elements.

@chomosuke
Copy link
Owner Author

I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhel shangzhel shangzhel approved these changes

@waltervan00 waltervan00 waltervan00 approved these changes

Assignees

@chomosuke chomosuke

Labels
enhancement New feature or request
Projects
Product backlog
  
Sprint 3 Done
Sprint 3
Done
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chomosuke @shangzhel @waltervan00