Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment stating that the string for image type will be a Base64 data URI #44

Merged
merged 2 commits into from
Aug 29, 2021
Merged

comment stating that the string for image type will be a Base64 data URI #44

merged 2 commits into from
Aug 29, 2021

Conversation

chomosuke
Copy link
Owner

@chomosuke chomosuke commented Aug 28, 2021 •
edited
Loading

I'm just checking I'm on the right path here.

We'll use Jimp.read(Buffer.from(image, 'base64')); to read the data URI, and image.getBase64Async(mime) to encode an image into the data URI.

@chomosuke chomosuke added the documentation Improvements or additions to documentation label Aug 28, 2021
@chomosuke chomosuke added this to the Sprint 1 milestone Aug 28, 2021
@chomosuke chomosuke self-assigned this Aug 28, 2021
@chomosuke chomosuke added this to Sprint 1 in Product backlog via automation Aug 28, 2021
@chomosuke chomosuke added this to In progress in Sprint 1 via automation Aug 28, 2021
@chomosuke chomosuke moved this from In progress to In review in Sprint 1 Aug 29, 2021
@chomosuke chomosuke requested review from shangzhel and removed request for shangzhel August 29, 2021 11:17
shangzhel
shangzhel approved these changes Aug 29, 2021
View reviewed changes
Copy link
Collaborator

@shangzhel shangzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chomosuke chomosuke merged commit 2eb7f7d into docs Aug 29, 2021
Sprint 1 automation moved this from In review to Done Aug 29, 2021
Product backlog automation moved this from Sprint 1 to Sprint 1 Done Aug 29, 2021
@chomosuke chomosuke deleted the docs-dataURI-as-image branch August 29, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhel shangzhel shangzhel approved these changes

Assignees

@chomosuke chomosuke

Labels
documentation Improvements or additions to documentation
Projects
Product backlog
  
Sprint 1 Done
Sprint 1
  
Done
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chomosuke @shangzhel