-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement app lifecycle #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the method does not actually send PATCH request if update has never been called on that card.
…yPro into shangzhel/lifecycle
oldbugo
approved these changes
Sep 6, 2021
waltervan00
approved these changes
Sep 6, 2021
chomosuke
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some random opinions about where things should be but other than that it looks good.
Merging it now because it's blocking literally everyone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54.
Interface changes:
newCard
is no longer a free function, and has become a callback ofIAppContext
. Calling it causes a blank card to be shown in the card detail pane. The callback does not return anything (() => void
) because all React state changes are asynchronous.update
orcommit
on anICard
will throw unless it is the one obtained from thedetail
prop ofHome
.commit
on a detailICard
that is not new and has not been modified will resolve but not actually send a PATCH request.Also included:
Note:
controllers
subdirectory, all that can be found in them are interface definitions for the controllers.web/src/App.tsx
instead, because they are coupled with user state, where the card information is actually represented, and network activity.