Walter/login view #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into walter/loginView
shangzhel
requested changes
Sep 9, 2021
There was a problem hiding this comment.
There is a React warning about calling setUsername and setPassword after the component had been unmounted. This happens when registering and the entire component re-renders upon success.
Let's not deal with appearances now, leave that to #56. I insist this because visual consistency follows from all visual styling being done at once. So far this view is functional, and that is all that matters for now.
I have addressed both issues on my branch f4fb591, so you can just fast-forward merge it.
chomosuke
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Login View for the website, hooked to lifecycle calls.
Fields display error messages when they are empty.
Error may appear despite user clicking on router link, may be seen as a graphical glitch.
Closes #3.