Add app header component. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltervan00
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
I was playing around with login in through the console and logging out through the button. The functionality works, and the token was successfully removed from the browser upon login out.
However, when navigating through the history I was able to render the root directory view (where the Header shows the textbox). It sounds more like a bug with the lifecycle process or routing mechanics? Shall I start a bug issue to tackle this later?
Steps to reproduce effect:
- Logged into / page, supposedly me view
- Logout with button, redirected to /login page
- Seeking back in browser's history and returning to page. I would expect it to render /login but / page appeared to be rendered as indicated by address bar and expanded header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50.