Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag components + unit test #95

Merged
merged 5 commits into from
Sep 22, 2021
Merged

add tag components + unit test #95

merged 5 commits into from
Sep 22, 2021

Conversation

pep1032314
Copy link
Collaborator

Double check pls

Style elements including the function to change tag label color depending on the background color are not finalized, will be finalized with #56,
Closes #83

result should look like this V
image

@pep1032314 pep1032314 added the enhancement New feature or request label Sep 17, 2021
@pep1032314 pep1032314 added this to the Sprint 2 milestone Sep 17, 2021
@pep1032314 pep1032314 added this to In progress in Sprint 2 via automation Sep 17, 2021
@pep1032314 pep1032314 added this to Sprint 2 in Product backlog via automation Sep 17, 2021
@pep1032314 pep1032314 self-assigned this Sep 17, 2021
Copy link
Collaborator

@oldbugo oldbugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visual style aspects of the code is not the convention we are currently using across other pages/components.

See if you are able to adapt it to the getClassNames = () => mergeStyleSets ({...}).
Have a look at line 17 - 26 of CardDetails.tsx

Sprint 2 automation moved this from In progress to In review Sep 18, 2021
@pep1032314
Copy link
Collaborator Author

The visual style aspects of the code is not the convention we are currently using across other pages/components.

See if you are able to adapt it to the getClassNames = () => mergeStyleSets ({...}).
Have a look at line 17 - 26 of CardDetails.tsx

Thanks for the comment, will look into that today

@chomosuke chomosuke removed their request for review September 19, 2021 04:50
Copy link
Collaborator

@shangzhel shangzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change.

web/src/components/Tag.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@waltervan00 waltervan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shangzhel
Copy link
Collaborator

Merging this because it blocks #84.

@shangzhel shangzhel merged commit e9559cc into master Sep 22, 2021
Sprint 2 automation moved this from In review to Done Sep 22, 2021
Product backlog automation moved this from Sprint 2 to Sprint 2 Done Sep 22, 2021
@shangzhel shangzhel deleted the Pep/tag-components branch September 22, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Product backlog
  
Sprint 2 Done
Sprint 2
  
Done
Development

Successfully merging this pull request may close these issues.

Create tag component
4 participants