-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tag components + unit test #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visual style aspects of the code is not the convention we are currently using across other pages/components.
See if you are able to adapt it to the getClassNames = () => mergeStyleSets ({...}).
Have a look at line 17 - 26 of CardDetails.tsx
Thanks for the comment, will look into that today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Merging this because it blocks #84. |
Double check pls
Style elements including the function to change tag label color depending on the background color are not finalized, will be finalized with #56,
Closes #83
result should look like this V
![image](https://user-images.githubusercontent.com/88422113/133788283-9b0886e0-ac2d-4e86-9d2f-12dc387911c3.png)