Indeterminate checkbox property #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
approved these changes
May 24, 2020
|
📦 5.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML living standard defines the
indeterminateproperty for checkboxes. It cannot be set using an HTML attribute though, only through JavaScript. Currently, the choo DOM diffing does not respect this property.I have added test cases for the
checkboxanddisabledproperties as a separate commit, since I expected them to behave similar toindeterminate. However, attempting to allow setting the property like<input type="checkbox" indeterminate=${false}>does not do the expected thing and would still set the property totrue.Refs: