Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit next state when changing state, not eventName #9

Merged
merged 1 commit into from
Feb 12, 2018
Merged

emit next state when changing state, not eventName #9

merged 1 commit into from
Feb 12, 2018

Conversation

kareniel
Copy link
Member

@kareniel kareniel commented Feb 7, 2018 •
edited
Loading

  • call nanobus.prototype.emit w/ nextState
  • add test case

addresses #8

@kareniel
emit next state when changing state, not eventName
06a6bba 
- call nanobus.prototype.emit w/ nextState
- add test case
yoshuawuyts
yoshuawuyts approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshuawuyts yoshuawuyts merged commit d56390b into master Feb 12, 2018
@yoshuawuyts yoshuawuyts deleted the emit-state branch February 12, 2018 11:58
@yoshuawuyts
Copy link
Member

v1.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kareniel @yoshuawuyts