Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling/ignoring caching #476

Closed
vjanelle opened this issue Nov 7, 2018 · 1 comment
Closed

Support disabling/ignoring caching #476

vjanelle opened this issue Nov 7, 2018 · 1 comment
Labels
enhancement

Comments

@vjanelle
Copy link
Member

vjanelle commented Nov 7, 2018

As discussed on slack, for the use case of short lived certificates, it might be advantageous to disable caching, or at the very least replace them with each observation.
@ripienaar
Copy link
Member

This one is pretty simple, we add a new property under:

go-choria/config/config.go

Line 83 in d99b9a2

SecurityProvider string `confkey:"plugin.security.provider" default:"puppet" validate:"enum=puppet,file"`

Make a boolean called SecurityAlwaysOverwriteCache with confkey:"plugin.security.always_overwrite_cache" and default:"false"

And then we'll need a ticket in go-security as well to make the file security plugin use that.

@vjanelle vjanelle mentioned this issue Nov 13, 2018
Closed
vjanelle added a commit to vjanelle/go-choria that referenced this issue Nov 14, 2018
@vjanelle
(choria-io#476) Add configuration flag to always overwrite the cache
1bf5a64 
Support configuration where local file cache of certificates is always
overwritten

Fix fact discovery so that ginkgo works locally
vjanelle added a commit to vjanelle/go-choria that referenced this issue Nov 14, 2018
@vjanelle
(choria-io#476) Add configuration flag to always overwrite the cache
62dd868 
Support configuration where local file cache of certificates is always
overwritten

Fix fact discovery so that ginkgo works locally
vjanelle added a commit to vjanelle/go-choria that referenced this issue Nov 14, 2018
@vjanelle
(choria-io#476) Add configuration flag to always overwrite the cache
c973221 
Support configuration where local file cache of certificates is always
overwritten

Fix fact discovery so that ginkgo works locally
vjanelle added a commit to vjanelle/go-choria that referenced this issue Nov 15, 2018
@vjanelle
(choria-io#476) Add configuration flag to always overwrite the cache
b8ce6f3 
Support configuration where local file cache of certificates is always
overwritten

Fix fact discovery so that ginkgo works locally
vjanelle added a commit to vjanelle/go-choria that referenced this issue Nov 15, 2018
@vjanelle
(choria-io#476) Add configuration flag to always overwrite the cache
ca6d26b 
Support configuration where local file cache of certificates is always
overwritten

Fix fact discovery so that ginkgo works locally

Update docs to reflect changes to security providers about ignoring
cache
vjanelle added a commit to vjanelle/go-choria that referenced this issue Nov 15, 2018
@vjanelle
(choria-io#476) Add configuration flag to always overwrite the cache
196aa38 
Support configuration where local file cache of certificates is always
overwritten

Fix fact discovery so that ginkgo works locally

Update docs to reflect changes to security providers about ignoring
cache
ripienaar added a commit that referenced this issue Nov 15, 2018
@ripienaar
Merge pull request #479 from vjanelle/conf_overwrite_cache
2ece4ea 
(#476) Add configuration flag to always overwrite the cache
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ripienaar @vjanelle