(#751) Improve project parsing #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had InitiatedByServer to indicate server specific behaviours and we overloaded that to assume all system components are servers. This is not true for the broker. Now we have ways to create a system configuration with InitiatedBySystem set, the projects parsing and puppet security system uses that to do the right thing - avoid loading projects and use the system TLS when not configured Signed-off-by: R.I.Pienaar <rip@devco.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had InitiatedByServer to indicate server
specific behaviours and we overloaded that to assume all
system components are servers. This is not true for the
broker.
Now we have ways to create a system configuration with
InitiatedBySystem set, the projects parsing and puppet
security system uses that to do the right thing - avoid
loading projects and use the system TLS when not configured
Signed-off-by: R.I.Pienaar rip@devco.net