(#22) Added support for checkupdates and apt_checkupdates #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Aug 8, 2018
| @@ -108,6 +110,9 @@ def main | |||
| if ['count', 'md5'].include?(configuration[:action]) | |||
| status = "%s" % [result[:data][:output]] | |||
| puts(pattern % [result[:sender], status]) | |||
| elsif ['yum_checkupdates', 'apt_update', 'checkupdates', 'apt_checkupdates'].include?(configuration[:action]) | |||
| status = result[:data][:outdated_packages].map{ |package| package[:package] }.join(' ') | |||
| puts(pattern % [result[:sender], status]) | |||
There was a problem hiding this comment.
why the 2 different formats? I think this is quite nice rather than the format above?
There was a problem hiding this comment.
I tough having more information is good, but perhaps this went a bit to far with returning all information. Updated code to return name + version in verbose mode
ripienaar
requested changes
Aug 9, 2018
application/package.rb
Outdated
| puts(pattern % [result[:sender], result[:data][:ensure]]) | ||
| elsif ['yum_checkupdates', 'apt_update', 'checkupdates', 'apt_checkupdates'].include?(configuration[:action]) | ||
| status = result[:data][:outdated_packages].map{ |package| "%s-%s" % package[:package], package[:version] }.join(' ') |
There was a problem hiding this comment.
tests failing here, should be "%s-%s" % [foo, bar]
make verbose return name+version fix failing test
Merge branch 'master' of https://github.com/KoenDierckx/package-agent
|
I fixed the tests |
|
Thanks :) I'll see if I can squash it for you, thanks a lot, will review soon |
ripienaar
changed the title
ripienaar
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.