Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stalls on vim start #1

Closed
codebutcher opened this issue Aug 13, 2015 · 3 comments
Closed

stalls on vim start #1

codebutcher opened this issue Aug 13, 2015 · 3 comments

Comments

@codebutcher
Copy link

The player stalls with the vim status-bar and a blank screen every time vim is run
The player then ceases to function due to a JS error

screen shot 2015-08-13 at 08 19 43

This issue was produced on chrome

The scenario generates the following JS error (in term.js):
screen shot 2015-08-13 at 08 48 28

short analysis : term is receiving 23 lines of input in vi mode when screen height is 24 lines

@chris-morgan
Copy link
Owner

This looks like a term.js bug, but I’ll need a little more to diagnose is precisely.

Could you please post the following:

  • a sample ttyrec file that demonstrates this;
  • the specific version of term.js being used?

@codebutcher
Copy link
Author

  1. attaching a sample
  2. using the term.js from the ttyplayer repo.

On Thu, Aug 13, 2015 at 9:14 AM, Chris Morgan notifications@github.com
wrote:

This looks like a term.js bug, but I’ll need a little more to diagnose is
precisely.

Could you please post the following:

  • a sample ttyrec file that demonstrates this;
  • the specific version of term.js being used?


Reply to this email directly or view it on GitHub
#1 (comment)
.

@chris-morgan
Copy link
Owner

(Attaching a .ttyrec file having failed, I was emailed the sample file.)

If you resize the tty-player to 180 columns wide, it works. It’s failing when it sends ESC[23;1H~«178 spaces», so it’s a simple overflow that term.js isn’t coping with—79 spaces on line 23, 80 on line 24, then it’s off the screen for the final 19 spaces.

If you use termrec for recording, it includes the width and height in the ttyrec script (you need to use a version of term.js including chjj/term.js#75 for it to work), so you wouldn’t run into this issue. You can also go specifying the cols and rows attributes on the tty-player element.

As for the exception itself, I was able to reduce it very effectively and have filed chjj/term.js#84 for the matter. As it is a term.js issue and not a tty-player issue (with the way of achieving the desired behaviour explained in the previous paragraph also), I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants