Cleaned up simcf source #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes R CMD check errors about including require() in the code. The functions could be written with requireNamespace, but there really isn't a reason to make these packages optional.
Fix error message in R CMD check: ``` Rd files with duplicated name 'cfFactorial': ‘cfFactorial.Rd’ ‘setfactorial.Rd’ ```
Aliases weren't caught
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
I was looking through simcf and in the process of understanding it accidentally refactored the code.
using require within the source. This is now deprecated, and it looks like most of them should be used as dependencies.