Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typography in README.md #3

Merged
merged 2 commits into from Oct 4, 2020
Merged

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Oct 3, 2020

I really like keyboard shorcuts rendered using <kbd>: Ctrl+C. Thus, I changed the README.md accordingly. Moreover, I switched from bold font to typewriter (where appropriate)

@chrisant996
Copy link
Owner

chrisant996 commented Oct 4, 2020

Ah, sweet, thanks! I didn't realize <kbd> could be used in markdown. 😁

@chrisant996 chrisant996 merged commit 2606c5a into chrisant996:master Oct 4, 2020
@koppor
Copy link
Contributor Author

koppor commented Oct 4, 2020

Yeah - markdown-lint (with the vs.code plugin) forbids it in rule MD033. One can configure it to allow certain HTML keys (and I configure it to always allow kbd 😇 )

@koppor koppor deleted the patch-1 branch October 4, 2020 21:12
@chrisant996 chrisant996 added the hacktoberfest-accepted Hacktoberfest credit label Oct 14, 2020
@chrisant996
Copy link
Owner

chrisant996 commented Oct 16, 2020

It turns out this is a problematic change, because the premake script for building the Clink documentation strips non-markdown things like <kbd> and <br>. This was a cosmetic preference, but it became a time sink. 😕

Update: I managed to get the documentation build system working again.

@koppor
Copy link
Contributor Author

koppor commented Oct 18, 2020

@chrisant996 Sorry for that! Could a GitHub check have checked that? (E.g., the output resulting of the change at #4)?

@chrisant996
Copy link
Owner

If Martin had made a check in advance for that, sure. If he'd even known it would be a problem.

A check can probably catch almost every possible problem. The cost of imagining every possible problem and adding checks for them probably outweighs the benefit. Since markdown doesn't support kbd tags, using them has a fair chance of exposing some issue somewhere. 😉

In this case, I would have eventually run into related problems anyway, and it mostly just changed when I had to investigate, rather than what. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest credit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants