Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS2019 build using GitHub workflow #4

Merged
merged 2 commits into from Oct 4, 2020

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Oct 4, 2020

(Thank you for continuing working on this project. I am eager to test #2)

I like the capability of GitHub to build binaries of OSS projects for free. This PR enables that for that projects. After building, the binaries are avilable at the "Actions" page at "Artifacts"

grafik

@koppor
Copy link
Contributor Author

koppor commented Oct 4, 2020

I tried with ConEmu. Shows following output:

Clink v1.1.0.edad8b
Copyright (c) 2012-2018 Martin Ridgers
Portions Copyright (c) 2020 Christopher Antos
http://github.com/chrisant996/clink

Microsoft Windows [Version 10.0.20150.1000]

cannot open D:/a/clink/clink/.build/vs2019/../../clink/lua/scripts/generator.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/lua/scripts/arguments.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/prompt.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/cmd.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/dir.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/env.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/exec.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/self.lua: No such file or directory
cannot open D:/a/clink/clink/.build/vs2019/../../clink/app/scripts/set.lua: No such file or directory
attempt to call a nil value

attempt to call a nil value

attempt to call a nil value

attempt to call a nil value

attempt to call a nil value

attempt to call a nil value

I don't know why the build path is hard coded. Nevertheless, this PR could be a good start to build a release on GitHub.

@chrisant996
Copy link
Owner

chrisant996 commented Oct 4, 2020

I like the capability of GitHub to build binaries of OSS projects for free. This PR enables that for that projects. After building, the binaries are avilable at the "Actions" page at "Artifacts"

Oh sweet, thanks, I'll take a look soon!

Copy link
Owner

@chrisant996 chrisant996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thank you!

@chrisant996 chrisant996 merged commit a26c650 into chrisant996:master Oct 4, 2020
@chrisant996
Copy link
Owner

I tried with ConEmu. Shows following output:

Clink v1.1.0.edad8b
... 
Microsoft Windows [Version 10.0.20150.1000]

cannot open D:/a/clink/clink/.build/vs2019/../../clink/lua/scripts/generator.lua: No such file or directory
...

I don't know why the build path is hard coded. Nevertheless, this PR could be a good start to build a release on GitHub.

Curious! This is a great start, thanks for sharing it. Not sure what's going on there.

@koppor koppor deleted the add-github-workflow-msbuild branch October 4, 2020 21:24
@koppor
Copy link
Contributor Author

koppor commented Oct 4, 2020

I tried with msys2 (at koppor#1), but did not succeed: https://github.com/koppor/clink/runs/1206114803. Think it's about mkdir not able to make parent directories ^^.

@koppor
Copy link
Contributor Author

koppor commented Oct 13, 2020

I am work-overload with maintaining "my" open source project JabRef. May I ask to add the label hacktoberfest-accepted to this PR? Details: https://hacktoberfest.digitalocean.com/hacktoberfest-update

@chrisant996 chrisant996 added the hacktoberfest-accepted Hacktoberfest credit label Oct 14, 2020
@chrisant996
Copy link
Owner

The "Build" workflow stopped working. It looks like ilammy/msvc-dev-cmd was changed to detect some errors and abort. That seems to be causing the following errors in the Build workflow:

Run ilammy/msvc-dev-cmd@v1
Found with vswhere: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat
The system cannot find the path specified.
Error: [ERROR:winsdk.bat] Windows SDK 8.1 : 'include' not found
Error: [ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
Error: [ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
Error: [ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
Error: [ERROR:VsDevCmd.bat] Where [value] is:
Error: [ERROR:VsDevCmd.bat]    1 : basic debug logging
Error: [ERROR:VsDevCmd.bat]    2 : detailed debug logging
Error: [ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended.
Error: [ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
Error: [ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1
Error: Could not setup Developer Command Prompt: invalid parameters

I've disabled the Build workflow. I can re-enable it if/when a fix is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest credit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants