Add try-finally block to make sure we release the concurrency permit

Thanks @objcode
chrisbanes · Apr 4, 2019 · 97e05d4 · 97e05d4
1 parent ee8d7de
commit 97e05d4
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/base/src/main/java/app/tivi/extensions/CoroutineExtensions.kt b/base/src/main/java/app/tivi/extensions/CoroutineExtensions.kt
@@ -20,16 +20,19 @@ import kotlinx.coroutines.channels.Channel
 import kotlinx.coroutines.coroutineScope
 import kotlinx.coroutines.launch
 
-suspend fun <A, B> Collection<A>.parallelForEach(
+suspend fun <A> Collection<A>.parallelForEach(
     concurrency: Int = 10,
-    block: suspend (A) -> B
+    block: suspend (A) -> Unit
 ): Unit = coroutineScope {
     val semaphore = Channel<Unit>(concurrency)
     forEach { item ->
         launch {
             semaphore.send(Unit) // Acquire concurrency permit
-            block(item)
-            semaphore.receive() // Release concurrency permit
+            try {
+                block(item)
+            } finally {
+                semaphore.receive() // Release concurrency permit
+            }
         }
     }
 }