Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase java heap size to 2 GB #528

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Increase java heap size to 2 GB #528

merged 1 commit into from
Nov 13, 2019

Conversation

LivingWithHippos
Copy link
Contributor

Avoid "GC overhead limit exceeded" error while building. If this is not specified it should default to 1 GB, I wasn't able to run tivi without this.

Avoid "GC overhead limit exceeded" error while building
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@LivingWithHippos
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@chrisbanes
Copy link
Owner

Thanks! I intentionally didn't set this due to the priority order of Gradle handling the jvmargs properties.

Currently, our CI script overrides the max heap to ~5GB using JAVA_TOOL_OPTIONS, but org.gradle.jvmargs in gradle.properties has a higher priority so the env variable is ignored (the same thing happens when using GRADLE_OPTS).

I'll merge this and see what can be done for CI.

@chrisbanes chrisbanes merged commit fc52ee0 into chrisbanes:master Nov 13, 2019
@LivingWithHippos
Copy link
Contributor Author

According to https://docs.gradle.org/current/userguide/build_environment.html command line parameters have higher priority than gradle.properties.
At https://docs.gradle.org/current/userguide/command_line_interface.html#environment_options there's the parameter

-Dorg.gradle.jvmargs

    Set JVM arguments.

maybe this can be useful ;P

@chrisbanes
Copy link
Owner

chrisbanes commented Nov 14, 2019

Ah yes, thanks for researching 🙌. I went a different way, which I think works better with version control: a0271ec

This allows me to extract the config to a file, which is easier to update separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants