k8s-state: update-last-error: Fix non-fatal syntax error #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`undercover` fails to parse this particular line with the following message: ``` UNDERCOVER: Error while loading /Users/jjin/dev/kubernetes-el/kubernetes-state.el for coverage: UNDERCOVER: Invalid read syntax: "." UNDERCOVER: The problem may be due to edebug failing to parse the file. UNDERCOVER: You can try to narrow down the problem using the following steps: UNDERCOVER: 1. Open "/Users/jjin/dev/kubernetes-el/kubernetes-state.el" in an Emacs buffer; UNDERCOVER: 2. Run M-: ‘(require 'edebug)’; UNDERCOVER: 3. Run M-x ‘edebug-all-defs’; UNDERCOVER: 4. Run M-x ‘toggle-debug-on-error’. UNDERCOVER: 5. Run M-x ‘eval-buffer’; UNDERCOVER: 6. In the *Backtrace* buffer, find a numeric position, UNDERCOVER: then M-x ‘goto-char’ to it. ``` We can reproduce this w/ `edebug-defun` on the definition. As it turns out, substitution with `,` in a backquoted list runs "just fine" if the comma is not attached to the element to expand, as we can reproduce here: ```emacs-lisp (let ((foo t)) `(, foo)) ``` However, we fix up the definition for full correctness and so that undercover doesn't complain.
Nice. |
|
@jinnovation Will, you be interested in becoming co-maintainer of this project? |
noorul
approved these changes
Jun 4, 2021
I'd be happy to. That said, I can't and won't commit to always being as active as I have been lately. Go ahead and add me in. |
|
@chrisbarrett Can you please add @jinnovation to contributors list? |
@chrisbarrett: Bumping on this. Think you could help out here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undercoverfails to parse this particular line with the followingmessage:
We can reproduce this w/
edebug-defunon the definition.As it turns out, substitution with
,in a backquoted list runs "justfine" if the comma is not attached to the element to expand, as we can
reproduce here:
However, we fix up the definition for full correctness and so that
undercover doesn't complain.