Skip to content

Commit

Permalink
notif: For test-notification button, require FL 234+ instead of 217+
Browse files Browse the repository at this point in the history
Servers with FL 217+ but not 234+ will send a payload to the bouncer
that's missing realm_name, and the bouncer will error because it
assumes realm_name is present. See API changelog:
  https://zulip.com/api/changelog

So, require 234+. Like 217, 234 was released in Zulip Server 8.0, so
the error dialog we give the user should still be accurate:

  Feature not available

  This feature is only available for organizations on Zulip Server 8.0+.
  • Loading branch information
chrisbobbe authored and gnprice committed Feb 16, 2024
1 parent 1222bc9 commit 838c58e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/settings/PerAccountNotificationSettingsGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default function PerAccountNotificationSettingsGroup(props: Props): Node
}, [_, auth, pushToken]);

let testNotificationDisabled = false;
if (zulipFeatureLevel < 217) {
if (zulipFeatureLevel < 234) {
testNotificationDisabled = {
title: 'Feature not available',
message: {
Expand Down

0 comments on commit 838c58e

Please sign in to comment.