forked from zulip/zulip-mobile
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
logging: Make
logging.info
log to Sentry
We have a log line NotifTroubleshootingScreen: MailComposer reports a sent email. that I'd *thought* was getting sent to Sentry, but apparently not. The line is meant to help us detect potential cases where the user thought they'd contacted support through the app, but we don't see an email on our side. We're not aware of such cases yet, but in principle it could happen. Since it seems helpful to have a function for logging to Sentry at an "info" level, rewrite `logging.info` based on `logging.warn` and `logging.error` so it does that. That should cause that notif-troubleshooting line to go to Sentry. The one other callsite of `logging.info` is redundant with a breadcrumb added with the same information; remove it and an unexplained test assertion about it.
- Loading branch information
1 parent
6e06749
commit febaa93
Showing
3 changed files
with
13 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters