Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving puzzle type for all puzzles #17

Closed
mxrowanthomas opened this issue Jul 6, 2010 · 7 comments
Closed

Saving puzzle type for all puzzles #17

mxrowanthomas opened this issue Jul 6, 2010 · 7 comments
Assignees
Labels
feature The current behaviour is acceptable, but could be better
Milestone

Comments

@mxrowanthomas
Copy link

Keeping the settings defining the current settings (including any custom settings) for all games as opposed to just the current game. You could also store the entire game state but that might get large, storing the settings would be great though.

@wfaulk
Copy link

wfaulk commented Sep 30, 2010

I was just getting ready to submit a similar enhancement request, but it probably makes sense to add to yours. I'd like to see the option to save custom game modes rather than having to re-enter settings all the time.

@chrisboyle
Copy link
Owner

Should perhaps do some investigation and back-of-envelope maths at some point, but I would guess that storing all the game states would be ok with compression.

http://developer.android.com/reference/java/util/zip/GZIPOutputStream.html
http://developer.android.com/reference/java/util/zip/GZIPInputStream.html

@chrisboyle
Copy link
Owner

The chooser could then indicate which games have a game in progress/completed/started...

An alternative fix here is to just save the type settings as numberland originally suggested, and explicitly have a list of games in progress, which would allow multiple games of the same type (e.g. several Signpost games at once).

@marcelogp
Copy link

I was interested in this feature too, so I wrote a patch that save the state for each game into /sdcard/sgtpuzzles/ and load every time the user changes current game. It seems to work well.

I am kind of new to android dev, but if you want to check it out:
marcelogp@2823dbb

@chrisboyle
Copy link
Owner

Hi, thank you for your patch, and sorry I somehow missed it at the time! I'd actually really prefer to have this in the preferences framework so it gets backed up to the user's Google account, and doesn't get disrupted if an SD card is removed. I hope to look at this soon.

@chrisboyle
Copy link
Owner

Seems to work in 2d7c71e; should be in next release.

@chrisboyle
Copy link
Owner

Correction made at b167474 (was using game id, not params)

@chrisboyle chrisboyle self-assigned this Jul 9, 2015
@chrisboyle chrisboyle added this to the 10264.1 milestone Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The current behaviour is acceptable, but could be better
Projects
None yet
Development

No branches or pull requests

4 participants