Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG (vector) icons directly #621

Open
chrisboyle opened this issue Oct 15, 2023 · 0 comments
Open

Use SVG (vector) icons directly #621

chrisboyle opened this issue Oct 15, 2023 · 0 comments
Labels
controls Keyboards (virtual or real), D-pads, in-game UI, menus feature The current behaviour is acceptable, but could be better

Comments

@chrisboyle
Copy link
Owner

chrisboyle commented Oct 15, 2023

Now that minSdk is 21 to get Compose support, this also allows use of vector drawables for icons. Currently all of these button icons have been converted into PNGs in res/drawable-*dpi at 4 different sizes. Using SVGs directly would certainly be more maintainable, and might very slightly reduce the app size.

Note that the icons representing each game, as seen on the chooser, are generated from screenshots (in a similar way to upstream) so cannot benefit from this. The screenshots are of course generated by running the game with these save files and I could imagine generating SVGs instead, but the missing piece of that is an SVG-writing implementation of the Puzzles drawing API, and I'm not convinced it's worth creating one.

@chrisboyle chrisboyle added feature The current behaviour is acceptable, but could be better controls Keyboards (virtual or real), D-pads, in-game UI, menus labels Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Keyboards (virtual or real), D-pads, in-game UI, menus feature The current behaviour is acceptable, but could be better
Projects
None yet
Development

No branches or pull requests

1 participant