Fixed wrong Parameter in HiCol function #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbra
added a commit
that referenced
this pull request
Oct 4, 2011
Fixed wrong Parameter in HiCol function
|
Looks good. I am merging now. |
puremourning
pushed a commit
to puremourning/csv.vim
that referenced
this pull request
Jul 12, 2022
- Small enhancements to |SumCol_CSV|- :Filters! reapplys the dynamic filter- Apply |csv-aggregate-functions| only to those values, that are not folded away.- |SumCol_CSV| can use a different number format (suggested by James Cole, thanks! (also |csv-nrformat|- Documentation updates (suggested by James Cole and Peng Yu)- More code cleanup and error handling chrisbra#9 reported Daniel Carl, thanks! chrisbra#8 patch by Daniel Carl, thanks!- New Command |NewRecord_CSV| (suggest by James Cole, thanks!)- new textobjects InnerField (if) and outerField (af) which contain the field without or with the delimiter (suggested by James Cole, thanks!)- |csv-arrange-autocmd| to let Vim automatically visually arrange the columns using |ArrangeColumn_CSV|- |csv-move-folds| let Vim move folded lines to the end- implement a Menu for graphical Vim(automatically uploaded)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Fixed the missed bang parameter in HiCol function. The second commit indents the code. For me the code was very hard to read, with the indentation I can read it better. Maybe we can use early breakout to shorten the code and parsetime.
For Example:
if Condition
foo
bar
else
return ''
endif
could be done as following:
if !Condition
return ''
endinf
foo
bar