Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not write route if URL would not be different #2

Closed
wants to merge 2 commits into from
Closed

do not write route if URL would not be different #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9eae7
Update createInstantSearchRouting.js
Haroenv Aug 19, 2020
c269c40
Update src/modules/createInstantSearchRouting.js
Haroenv Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/modules/createInstantSearchRouting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@ export default ({ context, indexName }) => ({
});

if (typeof history === 'object') {
history.pushState(routeState, null, query || location.pathname);
// write query string if route would change only:
if (query && location.search !== query) {
// query is different
history.pushState(routeState, null, query);
} else if (location.search) {
// query string needs to be removed
history.pushState(routeState, null, location.pathname);
}
}
},
createURL(routeState) {
Expand Down